[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/28] i386/i386/db_interface.c (db_write_bytes): simplify co
|
From: |
Marin Ramesa |
|
Subject: |
Re: [PATCH 06/28] i386/i386/db_interface.c (db_write_bytes): simplify code |
|
Date: |
Mon, 09 Dec 2013 08:31:23 +0100 |
On 09.12.2013 06:40:25, Samuel Thibault wrote:
> Marin Ramesa, le Sun 08 Dec 2013 17:38:10 +0100, a écrit :
> > On 08.12.2013 16:46:20, Samuel Thibault wrote:
> > > Marin Ramesa, le Sun 08 Dec 2013 12:40:08 +0100, a écrit :
> > > > Remove assignments without any effect and unnecessary
> > > > variables.
> > >
> > > Err, *ptep0 assignment does have an effect, what makes you think
> > > otherwise?
> >
> > I don't see it.
>
> Well, it's among the lines you are removing:
>
> - *ptep0 = oldmap0;
Ah, I get it now.
BTW, thanks for the review. I will send corrections soon.
[PATCH 05/28] i386/i386/db_interface.c: remove forward declaration, Marin Ramesa, 2013/12/08
[PATCH 07/28] ddb/db_aout.c (aout_db_sym_init): remove unnecessary variable, Marin Ramesa, 2013/12/08
[PATCH 08/28] ddb/db_aout.c (aout_db_eq_name): remove unnecessary variable, Marin Ramesa, 2013/12/08
[PATCH 09/28] ddb/db_aout.c (aout_db_is_filename): remove unnecessary check, Marin Ramesa, 2013/12/08
[PATCH 10/28] ddb/db_aout.c (aout_db_qualified_search): use DB_SYM_NULL as return value, Marin Ramesa, 2013/12/08
[PATCH 11/28] ddb/db_aout.c (aout_db_lookup): remove forward declaration, Marin Ramesa, 2013/12/08