Re: [PATCH 06/13] trans: fix locking issue in fakeroot

[Samuel Thibault]

Justus Winter, le Mon 09 Dec 2013 15:16:34 +0100, a écrit :
> * trans/fakeroot.c (netfs_attempt_mkfile): Keep dir locked until the
>   new node is created.

Ack.

> ---
>  trans/fakeroot.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/trans/fakeroot.c b/trans/fakeroot.c
> index bee018e..b97b499 100644
> --- a/trans/fakeroot.c
> +++ b/trans/fakeroot.c
> @@ -614,9 +614,9 @@ netfs_attempt_mkfile (struct iouser *user, struct node 
> *dir,
>    file_t newfile;
>    error_t err = dir_mkfile (dir->nn->file, O_RDWR|O_EXEC,
>                           real_from_fake_mode (mode), &newfile);
> -  pthread_mutex_unlock (&dir->lock);
>    if (err == 0)
>      err = new_node (newfile, MACH_PORT_NULL, 0, O_RDWR|O_EXEC, np);
> +  pthread_mutex_unlock (&dir->lock);
>    return err;
>  }
>  
> -- 
> 1.7.10.4
> 

-- 
Samuel
<y> le y est un animal discret se logeant facilement dans un terminal
*** c has changed the topic on channel #ens-mim to ne pas jeter de cacahuetes 
aux ys, svp
 -+- #ens-mim - n'oubliez pas le guide -+-