[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/8] Quiet GCC warnings about set but unused variables
|
From: |
Marin Ramesa |
|
Subject: |
Re: [PATCH 4/8] Quiet GCC warnings about set but unused variables |
|
Date: |
Wed, 11 Dec 2013 21:07:38 +0100 |
On 11.12.2013 18:02:50, Richard Braun wrote:
> On Wed, Dec 11, 2013 at 05:30:43PM +0100, Marin Ramesa wrote:
> > - ipc_mqueue_t mqueue;
> > + ipc_mqueue_t mqueue = mqueue; /* Quiet GCC warning. */
>
> Don't do that. Instead, tweak simple_unlock and similar functions
> this way :
>
> #define simple_unlock(l) ((void)(l))
Then I have to define decl_simple_lock_data() which means we end up
with a lot of unused locks. And simple_lock_try() needs to always
suceed with the value TRUE which means locks can't be initialized to
zero.
It seems the best solution is to use #ifs for MACH_SLOCKS to declare
and set these unused variables.
[PATCH 3/8] Cleanup of the copyin() and copyout() calls, Marin Ramesa, 2013/12/11
[PATCH 5/8] include/mach/mach4.defs (memory_object_create_proxy): fix passing from incompatible pointer type, Marin Ramesa, 2013/12/11
[PATCH 6/8] vm/vm_kern.c (kmem_submap): remove unnecessary cast, Marin Ramesa, 2013/12/11
[PATCH 7/8] vm/vm_resident.c (vm_page_print): remove unnecessary casts, Marin Ramesa, 2013/12/11