[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/8] vm/vm_resident.c (vm_page_print): remove unnecessary cas
|
From: |
Marin Ramesa |
|
Subject: |
Re: [PATCH 7/8] vm/vm_resident.c (vm_page_print): remove unnecessary casts |
|
Date: |
Wed, 11 Dec 2013 21:11:32 +0100 |
On 11.12.2013 19:12:33, Ivan Shmakov wrote:
>
> Even though I’m unsure how vm_offset_t is defined (is it int?
> or is it ptrdiff_t? ¹), I’d rather like to see casts to /int/
> here, as it’s what %X (usually – no idea about vm/*) implies.
>
> ¹ Please note that while int is 32 bits on both i386 and amd64,
> the size of ptrdiff_t varies between the two.
It's unsigned long.
- Re: [PATCH 4/8] Quiet GCC warnings about set but unused variables, (continued)
[PATCH 3/8] Cleanup of the copyin() and copyout() calls, Marin Ramesa, 2013/12/11
[PATCH 5/8] include/mach/mach4.defs (memory_object_create_proxy): fix passing from incompatible pointer type, Marin Ramesa, 2013/12/11
[PATCH 6/8] vm/vm_kern.c (kmem_submap): remove unnecessary cast, Marin Ramesa, 2013/12/11
[PATCH 7/8] vm/vm_resident.c (vm_page_print): remove unnecessary casts, Marin Ramesa, 2013/12/11
[PATCH 8/8] mig/server.c (WriteVarDecls): quiet GCC warning about set but unused variable, Marin Ramesa, 2013/12/11