bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GCC's -fsplit-stack disturbing Mach's vm_allocate


From: Samuel Thibault
Subject: Re: GCC's -fsplit-stack disturbing Mach's vm_allocate
Date: Sat, 12 Apr 2014 01:04:49 +0200
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Samuel Thibault, le Fri 11 Apr 2014 23:51:44 +0200, a écrit :
> So, do we really want to let munmap poke a hole at address 0 and thus
> let further vm_map() return address 0?

i.e. we could apply this:

diff --git a/sysdeps/mach/munmap.c b/sysdeps/mach/munmap.c
index 57d99f9..a46e3f1 100644
--- a/sysdeps/mach/munmap.c
+++ b/sysdeps/mach/munmap.c
@@ -27,6 +27,11 @@ int
 __munmap (__ptr_t addr, size_t len)
 {
   kern_return_t err;
+  if (addr == 0)
+    {
+      errno = EINVAL;
+      return -1;
+    }
   if (err = __vm_deallocate (__mach_task_self (),
                             (vm_address_t) addr, (vm_size_t) len))
     {

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]