Re: [PATCH 1/2] include: do not guard the host_slab_info RPC with MACH_VM_DEBUG

[Samuel Thibault]

Justus Winter, le Wed 30 Apr 2014 14:55:15 +0200, a écrit :
> Previously, the definition of the host_slab_info RPC was guarded with
> MACH_VM_DEBUG, even though it is not at all concerned with the VM
> subsystem.  Furthermore, there was no "skip" directive for
> host_slab_info.
> 
> The function host_slab_info is guarded with MACH_DEBUG.  The server
> for the RPCs in mach_debug.defs is only used if MACH_DEBUG is
> defined. There is no need to guard host_slab_info.

Ack.

> * include/mach_debug/mach_debug.defs (host_slab_info): Unconditionally
> include the RPC.
> ---
>  include/mach_debug/mach_debug.defs | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/include/mach_debug/mach_debug.defs 
> b/include/mach_debug/mach_debug.defs
> index 053c3fe..fb6e3a9 100644
> --- a/include/mach_debug/mach_debug.defs
> +++ b/include/mach_debug/mach_debug.defs
> @@ -218,6 +218,12 @@ routine mach_vm_object_pages(
>       out     pages           : vm_page_info_array_t,
>                                       CountInOut, Dealloc);
>  
> +#else        /* !defined(MACH_VM_DEBUG) || MACH_VM_DEBUG */
> +skip;        /* mach_vm_region_info */
> +skip;        /* mach_vm_object_info */
> +skip;        /* mach_vm_object_pages */
> +#endif       /* !defined(MACH_VM_DEBUG) || MACH_VM_DEBUG */
> +
>  /*
>   *   Returns information about the memory allocation caches.
>   */
> @@ -225,9 +231,3 @@ routine host_slab_info(
>               host            : host_t;
>       out     info            : cache_info_array_t,
>                                       CountInOut, Dealloc);
> -
> -#else        /* !defined(MACH_VM_DEBUG) || MACH_VM_DEBUG */
> -skip;        /* mach_vm_region_info */
> -skip;        /* mach_vm_object_info */
> -skip;        /* mach_vm_object_pages */
> -#endif       /* !defined(MACH_VM_DEBUG) || MACH_VM_DEBUG */
> -- 
> 1.9.2
> 

-- 
Samuel
Who wants to remember that escape-x-alt-control-left shift-b puts you into
super-edit-debug-compile mode?
(Discussion in comp.os.linux.misc on the intuitiveness of commands, especially
Emacs.)