Re: [PATCH 8/8] startup: bind the startup server to /servers/startup

[Justus Winter]

Hi Roland :)

Quoting David Michael (2014-09-18 23:14:17)
> On Wed, Sep 3, 2014 at 8:33 AM, Justus Winter
> <4winter@informatik.uni-hamburg.de> wrote:
> > Bind the startup server to /servers/startup instead.  Use this to
> > contact the startup server.
> 
> I'm trying to test this patch, and glibc appears to need an update as
> well.  Does this look okay?
> 
> Thanks.
> 
> David
> 
> 
> diff --git a/sysdeps/mach/hurd/reboot.c b/sysdeps/mach/hurd/reboot.c
> index 60d96ea..51c3d73 100644
> --- a/sysdeps/mach/hurd/reboot.c
> +++ b/sysdeps/mach/hurd/reboot.c
> @@ -18,6 +18,7 @@
>  #include <errno.h>
>  #include <unistd.h>
>  #include <hurd.h>
> +#include <hurd/paths.h>
>  #include <hurd/startup.h>
>  #include <sys/reboot.h>
> 
> @@ -33,8 +34,8 @@ reboot (int howto)
>    if (err)
>      return __hurd_fail (EPERM);
> 
> -  err = __USEPORT (PROC, __proc_getmsgport (port, 1, &init));
> -  if (!err)
> +  init = __file_name_lookup (_SERVERS_STARTUP, 0, 0);
> +  if (init != MACH_PORT_NULL)
>      {
>        err = __startup_reboot (init, hostpriv, howto);
>        __mach_port_deallocate (__mach_task_self (), init);

I'd love to draw your attention to this thread.  The short story is
that we want to change how we interact with the init server.
Previously, the message port was looked up using proc_getmsgport, but
this turned out to be not ideal since a/ we changed the pid of the
init server to free pid 1 for sysvinit, and b/ this lookup mechanism
is not easily interposable.

Thanks,
Justus