Re: [PATCH] Fixed leaks in _netfs_translator_callback2_fn

[Flávio Cruz]

Thanks for noticing!
 

@@ -79,6 +82,7 @@ _netfs_translator_callback2_fn (void *cookie1, void *cookie2, int flags,
     }
   else
     {
+      netfs_release_peropen (po);
       iohelp_free_iouser (user);
       return errno;
     }

Maybe here we should do it as follows:

err = errno;

netfs_release_peropen (po);

iohelp_free_iouser (user);
return err;

I've seen this pattern a few times in other files since the release calls may reassign errno. 

--

Flávio Cruz / flaviocruz@gmail.com