bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fixed leaks in _netfs_translator_callback2_fn


From: Samuel Thibault
Subject: Re: [PATCH] Fixed leaks in _netfs_translator_callback2_fn
Date: Mon, 8 Feb 2016 00:15:34 +0100
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

James Clarke, on Sun 07 Feb 2016 23:13:06 +0000, wrote:
> > On 7 Feb 2016, at 23:10, Samuel Thibault <samuel.thibault@gnu.org> wrote:
> > Flávio Cruz, on Sun 07 Feb 2016 23:57:25 +0100, wrote:
> >> Maybe here we should do it as follows:
> >> 
> >> err = errno;
> >> netfs_release_peropen (po);
> >> iohelp_free_iouser (user);
> >> return err;
> > 
> > Yes, you never know what they could be doing to errno.
> > 
> > Samuel
> 
> Does that include changing
> 
> >   po = netfs_make_peropen (node, flags, cookie2);
> >   if (! po)
> > -    return errno;
> > +    {
> > +      iohelp_free_iouser (user);
> > +      return errno;
> > +    }
> 
> to
> 
> >   po = netfs_make_peropen (node, flags, cookie2);
> >   if (! po)
> > -    return errno;
> > +    {
> > +      err = errno;
> > +      iohelp_free_iouser (user);
> > +      return err;
> > +    }

I'd say so too, yes.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]