bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use libihash to store directory entries in ftpfs.


From: Justus Winter
Subject: Re: [PATCH] Use libihash to store directory entries in ftpfs.
Date: Thu, 11 Feb 2016 20:38:15 +0100
User-agent: alot/0.3.8.dev

Quoting Flavio Cruz (2016-02-07 21:53:53)
> * ftpfs/ftpfs.h: Add dir_locp for each directory entry and replace the table 
> with a libihash table.
> * ftpfs/dir.c: Modify the code to use libihash. Remove several functions such 
> as rehash and insert.

Your changelog entries are very long, please do reflow them to a
reasonable length.  I don't know what the reasonable length is, but I
always reflow them using meta-q in emacs.

> ---
> -
> 
> +
> [...]
> -
> 
> +
> [...]
> -
> 
> +
> [...]
> -
> 
> +
> [...]
> -
> 
> +
> [...]
> -
> 
> +
> [...]
> -
> 
> +
> [...]
> -
> 
> +

Your patch removes quite a lot of the form feed characters, is that on
purpose or an accident?  Fwiw, the coding conventions encourage their
use to break the source into logical segments.

Justus



reply via email to

[Prev in Thread] Current Thread [Next in Thread]