Re: [PATCH] Use uint32_t instead of unsigned32_t.

[Samuel Thibault]

Hello,

Flávio Cruz, on Sat 19 Mar 2016 14:20:34 +0100, wrote:
> We already include mach/std_types.h in the stubs which provides uint32_t.

I guess you mean it includes vm_types.h which defines them.

> diff --git a/i386/include/mach/i386/vm_types.h 
> b/i386/include/mach/i386/vm_types.h
> index 4a58b1c..b04c322 100644
> --- a/i386/include/mach/i386/vm_types.h
> +++ b/i386/include/mach/i386/vm_types.h
> +typedef signed char          int8_t;
> +typedef signed short         int16_t;
> +typedef int                  int32_t;
> +typedef signed long long     int64_t;
> +typedef unsigned char                uint8_t;
> +typedef unsigned short               uint16_t;
> +typedef unsigned int         uint32_t;
> +typedef unsigned long long   uint64_t;

Won't that risk conflicting with stdint.h?  If some application happens
to want to include both stdint.h and some mach headers (thus ending up
including vm_types.h).

Should gnumach perhaps just rely on stdint.h?

Samuel