Re: [PATCH] Use posix types for mig definitions.

[Samuel Thibault]

Flavio Cruz, on Tue 15 Mar 2016 05:49:51 -0400, wrote:
> * hurd/hurd_types.defs: Use posix types.
> * libfshelp/start-translator-long.c: Use uint32_t instead of
> unsigned32_t.

Applied, thanks!

> ---
>  hurd/hurd_types.defs              | 20 ++++++++++----------
>  libfshelp/start-translator-long.c |  3 ++-
>  2 files changed, 12 insertions(+), 11 deletions(-)
> 
> diff --git a/hurd/hurd_types.defs b/hurd/hurd_types.defs
> index 1837500..4d7013c 100644
> --- a/hurd/hurd_types.defs
> +++ b/hurd/hurd_types.defs
> @@ -349,16 +349,16 @@ serverprefix SERVERPREFIX;
>  type data_t = array[] of char;
>  type string_t = c_string[1024]; /* XXX */
>  type io_statbuf_t = struct[32] of int;
> -type uid_t = unsigned32;
> -type gid_t = unsigned32;
> -type mode_t = unsigned32;
> -type retry_type = unsigned32;
> -type pid_t = int32;
> -type wait_status_t = int32;
> -type loff_t = int64;
> -type ino64_t = int64;
> -type file_changed_type_t = unsigned32;
> -type dir_changed_type_t = unsigned32;
> +type uid_t = uint32_t;
> +type gid_t = uint32_t;
> +type mode_t = uint32_t;
> +type retry_type = uint32_t;
> +type pid_t = int32_t;
> +type wait_status_t = int32_t;
> +type loff_t = int64_t;
> +type ino64_t = int64_t;
> +type file_changed_type_t = uint32_t;
> +type dir_changed_type_t = uint32_t;
>  
>  type portarray_t = array[] of mach_port_send_t;
>  type intarray_t = array[] of int;
> diff --git a/libfshelp/start-translator-long.c 
> b/libfshelp/start-translator-long.c
> index 8b00e08..da6f52e 100644
> --- a/libfshelp/start-translator-long.c
> +++ b/libfshelp/start-translator-long.c
> @@ -24,6 +24,7 @@
>  #include <errno.h>
>  #include <unistd.h>
>  #include <fcntl.h>
> +#include <stdint.h>
>  #include <string.h>
>  #include <assert.h>
>  #include "fshelp.h"
> @@ -107,7 +108,7 @@ service_fsys_startup (fshelp_open_fn_t 
> underlying_open_fn, void *cookie,
>      {
>        union
>        {
> -     unsigned32_t word;
> +        uint32_t word;
>       mach_msg_type_t type;
>        } t, c;
>        t.type = *type;
> -- 
> 2.6.4
> 
> 

-- 
Samuel
/*
 * [...] Note that 120 sec is defined in the protocol as the maximum
 * possible RTT.  I guess we'll have to use something other than TCP
 * to talk to the University of Mars.
 * PAWS allows us longer timeouts and large windows, so once implemented
 * ftp to mars will work nicely.
 */
(from /usr/src/linux/net/inet/tcp.c, concerning RTT [retransmission timeout])