[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: sysdeps/mach/hurd/profil.c (was: [PATCH] hurd: align -p and -pg beha
From: |
Samuel Thibault |
Subject: |
Re: sysdeps/mach/hurd/profil.c (was: [PATCH] hurd: align -p and -pg behavior on Linux) |
Date: |
Tue, 19 Apr 2016 00:56:29 +0200 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Samuel Thibault, on Thu 25 Feb 2016 15:23:13 +0100, wrote:
> > As there are accesses to variables shared between different threads,
> > should these be re-written to use GCC's atomic/sync load/store builtins
> > with appropriate semantics?
>
> The current way seems unsafe at least between update_waiter and
> fetch_samples, indeed. I'd say just go with a libc_lock.
Actually there is already a spinlock to protect all of what I mentioned
:) I have fixed the remaining initialization issue.
Samuel
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: sysdeps/mach/hurd/profil.c (was: [PATCH] hurd: align -p and -pg behavior on Linux),
Samuel Thibault <=