|
From: | Flávio Cruz |
Subject: | Re: [PATCH] Simple testsuite for MIG. |
Date: | Tue, 19 Apr 2016 01:49:35 +0200 |
Hello,
Flavio Cruz, on Wed 30 Mar 2016 02:33:37 +0200, wrote:
> On Wed, Mar 30, 2016 at 01:41:17AM +0200, Justus Winter wrote:
> > I like it a lot. May I suggest the following robustness fix? Seems
> > like the empty files are lost somewhere in my ci/package building
> > setup. Also I think we want copyright notices at least in the
> > framework files, not sure about the test vectors. Thougths?
>
> Sure. I agree that empty files are a bad idea. I'll let Samuel make the
> call about copyright notices and then I'll resubmit the patch.
Well, we need copyright notices on anything that is non-trivial. "empty"
files, or files which just #include something are trivial for instance,
since they are meant to be that simple. For anything else, it's better
to add a copyright notice, because otherwise if people adds code to them
they won't dare adding the copyright notice, and then we'd have
non-trivial files without copyright notice.
Thanks,
Samuel
[Prev in Thread] | Current Thread | [Next in Thread] |