[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Move user_intr handling to mach side
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH] Move user_intr handling to mach side |
|
Date: |
Wed, 5 Aug 2020 02:28:18 +0200 |
|
User-agent: |
NeoMutt/20170609 (1.8.3) |
Samuel Thibault, le mer. 05 août 2020 02:24:20 +0200, a ecrit:
> > user_intr_t *
> > insert_intr_entry (struct irqdev *dev, int id, ipc_port_t dst_port)
> > {
> [...]
> > + /* we do not need to disable irq here, because the irq handler does not
> > touch the queue now. */
> ??? How so?
Ah, you mean with the modifications, interrupts handler don't modify
the structure of the queue. Don't put "now" in comments to refer to git
history: the reader will be thinking "now" means during execution.
Samuel