Re: [RFC PATCH glibc 2/3] XXX: Move __pthread_threads to ld.so

[Samuel Thibault]

Sergey Bugaev, le dim. 09 mai 2021 16:54:03 +0300, a ecrit:
> index af340bee..a55834a1 100644
> --- a/elf/dl-support.c
> +++ b/elf/dl-support.c
> @@ -194,7 +194,9 @@ list_t _dl_stack_used;
>  list_t _dl_stack_user;
>  int _dl_stack_cache_lock;
>  #else
> -int _dl_thread_gscope_count;
> +int _dl_pthread_num_threads;
> +struct __pthread **_dl_pthread_threads;
> +int _dl_pthread_threads_lock;
>  void (*_dl_init_static_tls) (struct link_map *) = 
> &_dl_nothread_init_static_tls;
>  #endif
>  struct dl_scope_free_list *_dl_scope_free_list;

This can't go to the generic-purpose dl-support.c file.
Create a sysdeps/mach/hurd/dl-thread_gscope_wait.c file, it's already
getting included by elf/Makefile's routine variable.

> diff --git a/htl/Versions b/htl/Versions
> index 9506043c..07a343f9 100644
> --- a/htl/Versions
> +++ b/htl/Versions
> @@ -168,7 +168,7 @@ libpthread {
>    GLIBC_PRIVATE {
>      __pthread_initialize_minimal;
>  
> -    __pthread_threads;
> +    # __pthread_threads;

Just completely remove theses, we won't need to keep the old code any
more.

The rest looks ok, did you try to run make check to make sure nothing
broke?

Samuel