Re: [PATCH] hurd: Add support for rumpdisk device names

[Samuel Thibault]

Daniel Kiper, le mar. 22 févr. 2022 14:42:57 +0100, a ecrit:
> On Tue, Feb 22, 2022 at 12:48:45AM +0100, Samuel Thibault wrote:
> > On GNU/Hurd grub2 currently only looks at /dev/hd* and /dev/sd*.  With
> > rumpdisk we now also need to look at /dev/wd*
> >
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> >
> > Index: grub2-2.06/util/deviceiter.c
> > ===================================================================
> > --- grub2-2.06.orig/util/deviceiter.c
> > +++ grub2-2.06/util/deviceiter.c
> 
> Hmmm... This file does not exist in the GRUB upstream. Am I missing something?

Ah, that was removed indeed.

> > +#ifdef __GNU__
> > +  /* The rest is SCSI disks.  */
> 
> s/is/are/?
> 
> ... and are those really SCSI disks if you mention /dev/sd* in the
> commit message above?

Yes, there are different drivers which produce different namings.

Samuel