Re: [PATCH 3/5] acpi: Convert translator to an emulated mach device

[Damien Zammit]

Hi Samuel,

On 6/9/22 9:05 am, Samuel Thibault wrote:
> machdev_trivfs_server can probably be split into two functions, so that
> one can run the initialization part sequentially in the main thread,
> then initialize the rest, and then only start the libmachdev demuxer in
> another thread.

I can follow up with some machdev fixes but that seems independent to getting 
this working.

>> -  netfs_server_loop (); /* Never returns.  */
>> +  err = pthread_create (&nt, NULL, netfs_server_func, NULL);
>> +  if (err)
>> +    error (1, err, "creating netfs loop thread");
>> +  pthread_detach (nt);
>>
>> +  /* Let the other threads do their job */
>> +  pthread_exit(NULL);
>> +  /* Never reached */
>
> Why not leaving it calling netfs_server_loop?
> I don't remember why we did that in pci-arbiter/main.c.
> (which means we should have left a comment telling why)

You are right, it works the way you suggest.

I will include the amendment in my next patch set.

Damien