Re: [PATCH 0/4] move some htl symbol into libc

[Samuel Thibault]

Hello,

Guy-Fleury Iteriteka, le sam. 29 oct. 2022 12:56:22 +0100, a ecrit:
> Samuel can you help moving the pthread_self into libc as an
> example so that i can go ahead and move others that are not difficult
> for me.

I'd say contact on libc-alpha the people who did it on Linux, they do
know the pitfalls of the operation.

Samuel

> pthread_equal is removed from libpthread.so but
> with the patch for pthread_self is in both libc.so and libpthread.so.
> 
> this is libpthread.so
> -------
>          U ___pthread_self@GLIBC_PRIVATE
> 00006630 t __pthread_self
> 00006630 t pthread_self
> -------
> 
> and this libc.so
> -------
> 00000028 b __GI____pthread_self
> 00000028 B ___pthread_self
> 001cf570 T __pthread_self
> 001cf570 W pthread_self
> -------
> 
> i was thinking that it is with this makefile rule
> ------
> extra-B-pthread.so = -B$(common-objpfx)htl/
> ------
> in htl/Makefile that will force the pthread_self inclusion.
> that would explain why pthread_equal is remove because it is in 
> sysdeps/htl/.
> 
> thanks.
> Guy-Fleury Iteriteka (4):
>   htl: move __pthread-total into libc.
>   htl: move ___pthread_self to libc
>   htl: move pthread_equal into libc
>   htl: move pthread_self into libc
> 
>  htl/Makefile                              |  5 ++---
>  htl/Versions                              | 11 ++++++-----
>  htl/forward.c                             |  8 --------
>  htl/pt-create.c                           |  6 ------
>  htl/pt-initialize.c                       |  2 --
>  htl/pt-internal.h                         |  1 +
>  htl/pt-total.c                            | 23 +++++++++++++++++++++++
>  sysdeps/htl/pthread-functions.h           |  4 ----
>  sysdeps/mach/hurd/htl/pt-dep-self.c       | 22 ++++++++++++++++++++++
>  sysdeps/mach/hurd/htl/pt-sysdep.c         |  2 +-
>  sysdeps/mach/hurd/htl/pt-sysdep.h         |  3 +++
>  sysdeps/mach/hurd/i386/libc.abilist       |  2 ++
>  sysdeps/mach/hurd/i386/libpthread.abilist |  2 --
>  13 files changed, 60 insertions(+), 31 deletions(-)
>  create mode 100644 htl/pt-total.c
>  create mode 100644 sysdeps/mach/hurd/htl/pt-dep-self.c
> 
> -- 
> 2.37.2
> 
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.