Re: [PATCH] Make task_info.h structs more portable

[Flavio Cruz]

On Wed, Nov 30, 2022 at 10:21:28PM +0100, Samuel Thibault wrote:
> Flavio Cruz, le mer. 30 nov. 2022 02:10:16 -0500, a ecrit:
> >  @table @code
> > -@item natural_t faults
> > +@item unsigned int faults
> >  number of page faults
> >
> > -@item natural_t zero_fills
> > +@item unsigned int zero_fills
> >  number of zero fill pages
> >
> > -@item natural_t reactivations
> > +@item unsigned int reactivations
> >  number of reactivated pages
> >
> > -@item natural_t pageins
> > +@item unsigned int pageins
> >  number of actual pageins
> >
> > -@item natural_t cow_faults
> > +@item unsigned int cow_faults
> >  number of copy-on-write faults
> >
> > -@item natural_t messages_sent
> > +@item unsigned int messages_sent
> >  number of messages sent
> >
> > -@item natural_t messages_received
> > +@item unsigned int messages_received
>
> It would be more convenient for these to be 64bit on 64bit systems?
>
> Of course 64bit can overflow as well, but at least it makes it easy to
> write simple programs to get it and have very little probability of
> overflowing.

I think that should fine. Would it be ok to define a new type called 
rpc_unsigned_long to define those counters? It would be 32 bits or 64 
bits long depending on the userland.

Flavio
> Samuel