[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/4] add missing argument names
From: |
Luca Dariz |
Subject: |
[PATCH 1/4] add missing argument names |
Date: |
Mon, 16 Jan 2023 14:04:23 +0100 |
* ddb/db_break.c: add argument name, compilation fails on Debian/Linux
stable with gcc 10.2 otherwise. For some reason on Debian/Hurd a
simple test program without argname succeeds, unless I force
-std=c11 or similar; I suppose because newer gcc have different
defaults. Gnumach seem to still require c89 for some older code,
otherwise we could explicitely use gnu99/c99 or gnu11/c11.
* ddb/db_cond.c: Likewise
* ddb/db_examine.c: Likewise
* ddb/db_macro.c: Likewise
* ddb/db_watch.c: Likewise
* device/dev_name.c: Likewise
---
ddb/db_break.c | 16 ++++++++--------
ddb/db_cond.c | 8 ++++----
ddb/db_examine.c | 8 ++++----
ddb/db_macro.c | 24 ++++++++++++------------
ddb/db_watch.c | 8 ++++----
device/dev_name.c | 6 +++---
6 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/ddb/db_break.c b/ddb/db_break.c
index 780c1ccc..676f5ca3 100644
--- a/ddb/db_break.c
+++ b/ddb/db_break.c
@@ -598,10 +598,10 @@ db_list_breakpoints(void)
/*ARGSUSED*/
void
db_delete_cmd(
- db_expr_t,
- boolean_t,
- db_expr_t,
- const char *)
+ db_expr_t addr_,
+ int have_addr,
+ db_expr_t count,
+ const char * modif)
{
int n;
thread_t thread;
@@ -735,10 +735,10 @@ db_breakpoint_cmd(
/* list breakpoints */
void
db_listbreak_cmd(
- db_expr_t,
- boolean_t,
- db_expr_t,
- const char *)
+ db_expr_t addr,
+ int have_addr,
+ db_expr_t count,
+ const char * modif)
{
db_list_breakpoints();
}
diff --git a/ddb/db_cond.c b/ddb/db_cond.c
index 8f0c8b30..0644cf24 100644
--- a/ddb/db_cond.c
+++ b/ddb/db_cond.c
@@ -122,10 +122,10 @@ db_cond_print(bkpt)
void
db_cond_cmd(
- db_expr_t,
- boolean_t,
- db_expr_t,
- const char *)
+ db_expr_t addr,
+ int have_addr,
+ db_expr_t count,
+ const char * modif)
{
int c;
struct db_cond *cp;
diff --git a/ddb/db_examine.c b/ddb/db_examine.c
index 62a887ad..30799360 100644
--- a/ddb/db_examine.c
+++ b/ddb/db_examine.c
@@ -347,10 +347,10 @@ db_strcpy(char *dst, const char *src)
*/
void
db_search_cmd(
- db_expr_t,
- boolean_t,
- db_expr_t,
- const char *)
+ db_expr_t e,
+ boolean_t b,
+ db_expr_t e2,
+ const char * cc)
{
int t;
db_addr_t addr;
diff --git a/ddb/db_macro.c b/ddb/db_macro.c
index d417abe1..7f3300dc 100644
--- a/ddb/db_macro.c
+++ b/ddb/db_macro.c
@@ -73,10 +73,10 @@ db_lookup_macro(const char *name)
void
db_def_macro_cmd(
- db_expr_t,
- boolean_t,
- db_expr_t,
- const char *)
+ db_expr_t addr,
+ int have_addr,
+ db_expr_t count,
+ const char * modif)
{
char *p;
int c;
@@ -108,10 +108,10 @@ db_def_macro_cmd(
void
db_del_macro_cmd(
- db_expr_t,
- boolean_t,
- db_expr_t,
- const char *)
+ db_expr_t addr,
+ int have_addr,
+ db_expr_t count,
+ const char * modif)
{
struct db_user_macro *mp;
@@ -128,10 +128,10 @@ db_del_macro_cmd(
void
db_show_macro(
- db_expr_t,
- boolean_t,
- db_expr_t,
- const char *)
+ db_expr_t addr,
+ int have_addr,
+ db_expr_t count,
+ const char * modif)
{
struct db_user_macro *mp;
int t;
diff --git a/ddb/db_watch.c b/ddb/db_watch.c
index 5db3f300..aa0f47b7 100644
--- a/ddb/db_watch.c
+++ b/ddb/db_watch.c
@@ -249,10 +249,10 @@ db_watchpoint_cmd(
/* list watchpoints */
void
db_listwatch_cmd(
- db_expr_t,
- boolean_t,
- db_expr_t,
- const char *)
+ db_expr_t addr,
+ int have_addr,
+ db_expr_t count,
+ const char * modif)
{
db_list_watchpoints();
}
diff --git a/device/dev_name.c b/device/dev_name.c
index 66e6eafe..4595d31c 100644
--- a/device/dev_name.c
+++ b/device/dev_name.c
@@ -39,7 +39,7 @@
/*
* Routines placed in empty entries in the device tables
*/
-int nulldev_reset(dev_t)
+int nulldev_reset(dev_t dev)
{
return (D_SUCCESS);
}
@@ -78,12 +78,12 @@ int nulldev_portdeath(dev_t dev, mach_port_t port)
return (D_SUCCESS);
}
-int nodev_async_in(dev_t, const ipc_port_t, int, filter_t*, unsigned int)
+int nodev_async_in(dev_t dev, const ipc_port_t port, int x, filter_t* filter,
unsigned int j)
{
return (D_INVALID_OPERATION);
}
-int nodev_info(dev_t, int, int*)
+int nodev_info(dev_t dev, int a, int* b)
{
return (D_INVALID_OPERATION);
}
--
2.30.2
- [PATCH 1/4] add missing argument names,
Luca Dariz <=