[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3 gnumach] apic: Use cpuid to read the apic id for speed
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 1/3 gnumach] apic: Use cpuid to read the apic id for speed |
Date: |
Sun, 13 Aug 2023 00:41:37 +0200 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
Damien Zammit, le ven. 11 août 2023 08:34:44 +0000, a ecrit:
> diff --git a/x86_64/locore.S b/x86_64/locore.S
> index 271a9071..402b9c85 100644
> --- a/x86_64/locore.S
> +++ b/x86_64/locore.S
> @@ -905,7 +905,7 @@ ast_from_interrupt:
> pusha /* save general registers */
> PUSH_SEGMENTS_ISR(%rdx)
> SET_KERNEL_SEGMENTS
> - CPU_NUMBER(%edx)
> + CPU_NUMBER_NO_STACK(%edx)
? Can't the CPU_NUMBER version work here? We make a "call" instruction
just below.
> @@ -1428,7 +1428,7 @@ _syscall64_call:
>
> _syscall64_check_for_ast:
> /* Check for ast. */
> - CPU_NUMBER(%r11)
> + CPU_NUMBER_NO_STACK(%r11)
> cmpl $0,CX(EXT(need_ast),%r11)
> jz _syscall64_restore_state
>
And here as well, we made a "call" instruction just above.
Samuel