Re: [PATCH 5/5] x86_64: remove unneeded segment selectors handling on full 64 bit

[Samuel Thibault]

Hello,

Luca Dariz, le mer. 09 août 2023 20:20:42 +0200, a ecrit:
> Il 04/08/23 23:50, Samuel Thibault ha scritto:
> > Luca Dariz, le sam. 29 juil. 2023 19:47:53 +0200, a ecrit:
> > > @@ -803,10 +809,7 @@ kern_return_t thread_getstatus(
> > >                                   == 0)
> > >                               saved_state->efl &= ~EFL_IF;
> > >                       }
> > > -         }
> > > -         else
> > > -#endif
> > > -         {
> > > +         } else {
> > >                       /*
> > >                        * 386 mode.
> > >                        */
> > > @@ -815,6 +818,7 @@ kern_return_t thread_getstatus(
> > >                       state->fs = saved_state->fs & 0xffff;
> > >                       state->gs = saved_state->gs & 0xffff;
> > >                   }
> > > +#endif
> > 
> > Mmm, I believe we shall then drop [gfed]s from i386_thread_state?
> > Otherwise we'll leak content in the structure in thread_getstatus calls.
> 
> Yes, they would not be necessary anymore. It seems this would also require
> to adapt glibc accordingly in sysdeps/mach/hurd/x86_64/bits/sigcontext.h, I
> tried bootstrapping the whole system with a simple patch but failed so far.

I have fixed this in gnumach & glibc.

Samuel