Re: Libtool Bourne shell portability bug

[Michael Sokolov]

Alexandre Oliva <address@hidden> wrote:

> How about:
>
> [good code fragment]
>
> ?

Looks good to me. I can't test it right now (I can't do a libstd++-v3 test
build right now as my C++ compiler is in the process of rebuilding, I'm testing
some major changes I have in store), but I trust you. Below is the revised
patch using your new code fragment.

-- 
Michael Sokolov
Public Service Agent
International Engineering and Science Task Force

1351 VINE AVE APT 27            Phone: +1-714-738-5409
FULLERTON CA 92833-4291 USA     (home office)

E-mail: address@hidden (ARPA TCP/SMTP)

2001-01-25  Michael Sokolov  <address@hidden>

        * ltconfig.in: Shell portability fix for the tagname validity check.

Index: ltconfig.in
===================================================================
RCS file: /home/cvs/libtool/Attic/ltconfig.in,v
retrieving revision 1.246.2.40
diff -p -r1.246.2.40 ltconfig.in
*** ltconfig.in 2000/12/16 13:50:25     1.246.2.40
--- ltconfig.in 2001/01/26 07:19:17
*************** fi
*** 422,429 ****
  
  if test -n "$tagname"; then
    # Check whether tagname contains only valid characters
!   case "$tagname" in
!   *[!-_A-Za-z0-9,/]*)
      echo "$progname: invalid tag name: $tagname" 1>&2
      exit 1
      ;;
--- 422,431 ----
  
  if test -n "$tagname"; then
    # Check whether tagname contains only valid characters
!   case `$echo "X$tagname" |
!         $Xsed -e 
's/[-_ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890,/]//g'` in
!   "") ;;
!   *)
      echo "$progname: invalid tag name: $tagname" 1>&2
      exit 1
      ;;