bug-libtool
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] config.cache problem


From: Ralf Wildenhues
Subject: [PATCH] config.cache problem
Date: Mon, 26 Jan 2004 23:04:32 +0100
User-agent: Mutt/1.5.5.1+cvs20040105i

Hi there,

config.cache does harmful things to variables with multi-line values
(but I'm not sure that's the origin of the problem).
This leads to errors such as:

| $ make
| /bin/sh ./config.status --recheck
| running /bin/sh ../configure  -C  --no-create --no-recursion
| configure: loading cache config.cache
| ./config.cache: 141: Syntax error: Unterminated quoted string
| make: *** [config.status] Fehler 2

where the culprit is on line 120 (sic), being wrong-quoted

| libltdl_cv_sys_search_path=${libltdl_cv_sys_search_path='/lib /usr/lib 
/usr/X11R6/lib}

As you could have guessed, this is on linux.  A quick patch which fixes
this is below.  BTW: This one *is* independent of the dash/echo problem
I reported.  There might be other cases like this (e.g. I don't know if
ldconfig output on sunos4* contains newlines), so it might be better to
sanitize this in a common place.

Regards,
Ralf


2004-01-26  Ralf Wildenhues  <address@hidden>

        * m4/libtool.m4: Remove newlines from lt_ld_extra, so
        Variable can safely be stored in config.cache.


Index: m4/libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/m4/libtool.m4,v
retrieving revision 1.35
diff -u -r1.35 libtool.m4
--- m4/libtool.m4       22 Jan 2004 19:01:19 -0000      1.35
+++ m4/libtool.m4       25 Jan 2004 18:13:49 -0000
@@ -1842,7 +1842,7 @@
 
   # Append ld.so.conf contents to the search path
   if test -f /etc/ld.so.conf; then
-    lt_ld_extra=`$SED -e 's/[:,\t]/ /g;s/=[^=]*$//;s/=[^= ]* / /g' 
/etc/ld.so.conf`
+    lt_ld_extra=`$SED -e 's/[:,\t]/ /g;s/=[^=]*$//;s/=[^= ]* / /g' 
/etc/ld.so.conf | tr '\n' ' '`
     sys_lib_dlsearch_path_spec="/lib /usr/lib $lt_ld_extra"
   fi
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]