[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
FYI: tests/sh.test uses $SED without setting it
From: |
Ralf Wildenhues |
Subject: |
FYI: tests/sh.test uses $SED without setting it |
Date: |
Fri, 8 Jul 2005 17:28:06 +0200 |
User-agent: |
Mutt/1.4.1i |
* Derek Price wrote on Fri, Jul 08, 2005 at 05:20:14PM CEST:
> Ralf Wildenhues wrote:
> >* Derek Price wrote on Thu, Jul 07, 2005 at 07:06:37PM CEST:
> >
> >>While working on some other stuff, I noticed that tests/sh.test is
> >>calling $SED without it being set, though this was only causing a
*snip*
> >You omitted the patch. I believe you are talking about branch-1-5
> >Libtool, right? How about setting SED and Xsed in tests/defs?
>
> That would be fine, though it looks like tests/sh.test is the only test
> using $SED on 1.5. I've attached my original patch anyho in case you
> want it - it just adds `: ${SED=sed}' to an early line of tests/sh.test
> to set a default without overriding any environment.
Alright. I have applied this to branch-1-5. This issue is not present
in the other branches. IMHO it does not matter which sed is chosen
here.
Thanks!
Ralf
2005-07-08 Derek R. Price <address@hidden>
* tests/defs (SED): Default variable contents to `sed'.
Fixes false PASS of sh.test.
Index: tests/defs
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/Attic/defs,v
retrieving revision 1.5.2.3
diff -u -r1.5.2.3 defs
--- tests/defs 8 Apr 2005 13:00:50 -0000 1.5.2.3
+++ tests/defs 8 Jul 2005 15:26:53 -0000
@@ -17,8 +17,9 @@
progname=`echo "$0" | sed 's%^.*/%%'`
libtool="../libtool"
-make="${MAKE-make}"
SHELL="${CONFIG_SHELL-/bin/sh}"
+: ${MAKE=make}
+: ${SED=sed}
if echo a | (grep -E '(a|b)') >/dev/null 2>&1; then
EGREP='grep -E'
Re: FYI: ltmain.m4sh needs to handle spaces in paths, Derek Price, 2005/07/07