[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: Libtool head: Testsuite newline comparison problem.
From: |
Peter Ekberg |
Subject: |
RE: Libtool head: Testsuite newline comparison problem. |
Date: |
Thu, 25 Aug 2005 19:46:15 +0200 |
Ralf Wildenhues wrote:
> * Peter Ekberg wrote on Thu, Aug 25, 2005 at 12:24:04PM CEST:
> >
> > On MSYS (both MinGW and MSVC), test 17 and 18 fail because
> > of a line ending mixup. The test programs output text with
> > \r\n line endings, but the test suite generates the expected
> > output with \n line endings. For test 18 it is even a mix,
> > since the testsuite is adding one line with \n line endings
> > to the test program output (using echo >>"$at_output"). The
> > difference in line endings cause the comparison between
> > expected and actual output to fail.
> >
> > The attached rather horrible hack, which is probably not
> > very correct, works around the problem. A solution should
> > probably be added to AT_CHECK and/or LT_AT_EXEC_CHECK.
>
> Yes, it should be solved in LT_AT_EXEC_CHECK.
>
> But I'd like a different solution now: Do not compare output,
> but return value only. Rationale: besides the EOL issues, I
> have seen debug output from cross compile environments that
> disturbs this as well (wine startup, for example).
>
> Also note that the use of AT_CHECK in the second example breaks
> with cross compilation.
>
> How about this patch instead?
>
> Cheers,
> Ralf
>
> * tests/standalone.at, tests/template.at: Do not compare
> output because of EOL issues. Resolve warnings, make cross-
> compilation aware.
> Reported by Peter Ekberg <address@hidden>.
Works! Please apply...
Cheer,
Peter