Re: libtool 1.5.22 -- bug in LT_DLMUTEX_GETERROR()

[Ralf Wildenhues]

Hi Alexis,

* Alexis Wilke wrote on Sat, Dec 31, 2005 at 08:04:05AM CET:
> 
> There is a really bad bug in LT_DLMUTEX_GETERROR() which checks if the
> lt_dlmutex_seterror_func [see SET] instead of the lt_dlmutex_geterror_func
> [see, here GET].

Thanks for this bug report.  I have applied this patch to branch-1-5 to
fix the issue.

Please note that the locking interfaces of libltdl are deprecated and
will be removed in libtool 2.0, because of various issues with them
(one of them being that they do not work correctly on all systems).

Cheers,
Ralf

2006-01-02  Alexis Wilke  <address@hidden>

        * libltdl/ltdl.c (LT_DLMUTEX_GETERROR): check if
        `lt_dlmutex_geterror_func' is set instead of
        `lt_dlmutex_seterror_func'.

Index: libltdl/ltdl.c
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/ltdl.c,v
retrieving revision 1.174.2.20
diff -u -r1.174.2.20 ltdl.c
--- libltdl/ltdl.c      13 Oct 2005 04:48:50 -0000      1.174.2.20
+++ libltdl/ltdl.c      2 Jan 2006 08:32:55 -0000
@@ -894,7 +894,7 @@
                (*lt_dlmutex_seterror_func) (errormsg);         \
        else    lt_dllast_error = (errormsg);   } LT_STMT_END
 #define LT_DLMUTEX_GETERROR(errormsg)          LT_STMT_START { \
-       if (lt_dlmutex_seterror_func)                           \
+       if (lt_dlmutex_geterror_func)                           \
                (errormsg) = (*lt_dlmutex_geterror_func) ();    \
        else    (errormsg) = lt_dllast_error;   } LT_STMT_END