Re: cygpath usage

[Ralf Wildenhues]

Hello Akim,

Thanks for the bug report.

* Akim Demaille wrote on Thu, Mar 29, 2007 at 05:13:01PM CEST:
> This is libtool 1.5.22, and I have seen the same problem with 1.5.23a.

FWIW, this is fixed in HEAD.

> # Fix the shell variable $srcfile for the compiler.
> fix_srcfile_path="`cygpath -w "$srcfile"`"
> 
> which obviously should have been
> 
> # Fix the shell variable $srcfile for the compiler.
> fix_srcfile_path='`cygpath -w "$srcfile"`'

I'm applying the "obvious" fix below.  ;-)

> There is gonna be hair for quotes.  Why don't you use
> functions?  My usual $0.02 :)

Well if your $0.02 were multiplied by an, umm, large factor, you could
probably pay someone (else) to do a nice clean rewrite of Libtool.
Alternatively, I'd welcome you to do to Libtool what you did to Autoconf
some years ago.

Cheers,
Ralf

2007-03-29  Ralf Wildenhues  <address@hidden>

        * libtool.m4 (AC_LIBTOOL_CONFIG) <fix_srcfile_path>: This
        variable needs escaping, too.
        Report by Akim Demaille.

Index: libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/libtool.m4,v
retrieving revision 1.314.2.174
diff -u -r1.314.2.174 libtool.m4
--- libtool.m4  18 Mar 2007 18:09:57 -0000      1.314.2.174
+++ libtool.m4  29 Mar 2007 17:09:33 -0000
@@ -4266,6 +4266,7 @@
     _LT_AC_TAGVAR(module_cmds, $1) \
     _LT_AC_TAGVAR(module_expsym_cmds, $1) \
     _LT_AC_TAGVAR(lt_cv_prog_compiler_c_o, $1) \
+    _LT_AC_TAGVAR(fix_srcfile_path, $1) \
     _LT_AC_TAGVAR(exclude_expsyms, $1) \
     _LT_AC_TAGVAR(include_expsyms, $1); do
 
@@ -4637,7 +4638,7 @@
 sys_lib_dlsearch_path_spec=$lt_sys_lib_dlsearch_path_spec
 
 # Fix the shell variable \$srcfile for the compiler.
-fix_srcfile_path="$_LT_AC_TAGVAR(fix_srcfile_path, $1)"
+fix_srcfile_path=$lt_fix_srcfile_path
 
 # Set to yes if exported symbols are required.
 always_export_symbols=$_LT_AC_TAGVAR(always_export_symbols, $1)