[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: LIBTOOL_DEPS wrong when AC_CANONICAL_BUILD not called before initial
From: |
Ralf Wildenhues |
Subject: |
Re: LIBTOOL_DEPS wrong when AC_CANONICAL_BUILD not called before initializing libtool |
Date: |
Sat, 15 Mar 2008 23:01:32 +0100 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
Hello Jakub,
* Jakub Bogusz wrote on Sat, Mar 15, 2008 at 02:56:28PM CET:
> Aaah, I put this shell conditional just to easily demonstrate the
> difference and hit another (already known) issue instead of the one
> I originally reported.
>
> So here is simpler example:
[...]
Thank you! I've applied this patch to fix this issue, and put you in
THANKS.
It would still be nice if we had a testcase for this in the testsuite.
For that, grepping the value of $OBJDUMP isn't going to work seamlessly.
Can you perchance also provide a small example that creates a library or
program, and an import library, which exposes this issue? It doesn't
matter whether you use Automake for this, or just plain
./libtool --mode=compile/--mode=link
calls just like in the new testsuite; however, the test should use
libtool to create the import lib.
Cheers, and thanks,
Ralf
2008-03-15 Ralf Wildenhues <address@hidden>
* libltdl/m4/ltoptions.m4 (AC_LIBTOOL_WIN32_DLL): Require
AC_CANONICAL_HOST.
* THANKS: Update.
Report by Jakub Bogusz.
Index: libltdl/m4/ltoptions.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/m4/ltoptions.m4,v
retrieving revision 1.12
diff -u -r1.12 ltoptions.m4
--- libltdl/m4/ltoptions.m4 6 Feb 2008 19:53:01 -0000 1.12
+++ libltdl/m4/ltoptions.m4 15 Mar 2008 18:44:19 -0000
@@ -143,7 +143,8 @@
])# win32-dll
AU_DEFUN([AC_LIBTOOL_WIN32_DLL],
-[_LT_SET_OPTION([LT_INIT], [win32-dll])
+[AC_REQUIRE([AC_CANONICAL_HOST])dnl
+_LT_SET_OPTION([LT_INIT], [win32-dll])
AC_DIAGNOSE([obsolete],
[$0: Remove this warning and the call to _LT_SET_OPTION when you
put the `win32-dll' option into LT_INIT's first parameter.])