Re: darwin fat binary support bugfix

[LiKai Liu]

Hi Peter,

I tested the $SED $basename fix for glib and it works. However, your 
expression:

darwin_filelist=`find unfat-$$ -type f -name \*.o -o -name \*.lo -exec 
basename '{}' ';' | sort -u`

Needs to force the precedence for -o, i.e.,

darwin_filelist=`find unfat-$$ -type f \( -name \*.o -o -name \*.lo 
\) -exec basename '{}' ';' | sort -u`

The corrected one works just as well. I personally prefer the $SED 
$basename version because the -exec version has to spawn a process for 
every filename that needs to be basename'd. I figure we can be slightly 
more efficient. ;-)

liulk

On Thu, 17 Apr 2008, Peter O'Gorman wrote:

> LiKai Liu wrote:
> > Hi all,
> > 
> > For darwin fat binary support in libtool, there is a line in ltmain.sh 
> > that should be changed.
> > 
> > Search for the comment that says "Okay now we have a bunch of thin 
> > objects, gota fatten them up :)". The line that follows has a part in the 
> > pipe that reads "xargs basename", which is incorrect as basename cannot 
> > process more than two arguments (the second argument being the suffix). It 
> > should read "$SED $basename" instead.
> 
> You're right, of course. Will fix, but we obviously need a working test
> for this, so it will take more than a minute.
> 
> Changing that line to:
> darwin_filelist=`find unfat-$$ -type f -name \*.o -o -name \*.lo -exec
> basename '{}' ';' | sort -u`
> 
> should work. Please let me know if it does not.
> 
> Thanks,
> Peter
>