Re: LT 2.2 series regression

[Ralf Wildenhues]

Hi Jeff,

* Jeff Squyres wrote on Tue, May 27, 2008 at 03:07:02PM CEST:
> On May 26, 2008, at 1:42 PM, Ralf Wildenhues wrote:
>>> I notice that you patched [opal/]libltdl/m4/libtool.m4 -- did you  
>>> mean to patch config/libtool.m4?   I tried patching both of these,
>>> but got the same result (listed above).
>>
>> Are you sure that you re-ran autogen.sh after patching
>> config/libtool.m4?  Because over here, I can reproduce
>> the fact that -KPIC was used before, and -fPIC with the
>> patch.
>
> I actually patched autogen.sh to add your patch in while it was running.  
> And I can confirm that it's there in the 2 m4 files (config/libtool.m4 
> and opal/libltdl/m4/libtool.m4) after autogen.sh completes.  But it is 
> *not* in configure.  Digging a little deeper, I wonder if we are running 
> the GNU tools in the wrong sequence in autogen.sh -- it does the 
> following (abridged output):
>
> [Running] autom4te --language=m4sh ompi_get_version.m4sh -o  
> ompi_get_version.sh
> [Running] aclocal
> [Running] autoheader
> [Running] autoconf
> [Running] libtoolize --automake --copy --ltdl
> [Running] automake --foreign -a --copy --include-deps
>
> Should we be running libtoolize much earlier, before aclocal?

Yes, and you should be running 'aclocal -I config' in the toplevel, if
you want config/*.m4 to take precedence over installed m4 files, for
example.  Technically, the first time you ever invoke autogen.sh on a
pristine SVN checkout, it may be necessary to run aclocal, then
libtoolize, then rerun aclocal, but I think the first aclocal invocation
is not necessary as long as AC_PROG_LIBTOOL is present in configure.ac.

At that point (when you have added -I config), your aclocal.m4 file will
shrink by about 340K in size.  Also, at that point you can start
thinking about simply removing the toplevel acinclude.m4 file, as
'aclocal -I config' will cause the needed macro files from config/ to be
m4_included from aclocal.m4.  One file less to keep up to date manually.
:-)

Cheers,
Ralf