Re: Misleading error message from lt_dlopen()

[Ralf Wildenhues]

Hello Jeff,

thanks for the test case, and sorry for the long delay.

* Jeff Squyres wrote on Fri, Oct 24, 2008 at 10:59:11PM CEST:
> On Oct 24, 2008, at 3:54 PM, Ralf Wildenhues wrote:
>
>> For fixing this, it would be really helpful to have a test case,
[...]
>
> I'm afraid that I wasn't adventurous enough to learn Autotest, but  
> here's a tarball that shows the problem:

Unfortunately, I don't have a fix yet.
But I have rewritten your example into a testsuite test:

Cheers,
Ralf

2009-01-23  Jeff Squyres  <address@hidden>
            Ralf Wildenhues <address@hidden>

        New test, expose wrong error message from lt_dlopen.
        * tests/lt_dlopen.at (lt_dlopen error messages): New file,
        new test, marked as XFAIL for now.
        * Makefile.am: Adjust.

diff --git a/Makefile.am b/Makefile.am
index 98feed4..bd1c6d0 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -474,6 +474,7 @@ TESTSUITE_AT        = tests/testsuite.at \
                  tests/am-subdir.at \
                  tests/lt_dlexit.at \
                  tests/lt_dladvise.at \
+                 tests/lt_dlopen.at \
                  tests/ltdl-api.at \
                  tests/need_lib_prefix.at \
                  tests/standalone.at \
diff --git a/tests/lt_dlopen.at b/tests/lt_dlopen.at
new file mode 100644
index 0000000..0e92d2d
--- /dev/null
+++ b/tests/lt_dlopen.at
@@ -0,0 +1,104 @@
+# lt_dlopen.at -- test libltdl functionality                -*- Autotest -*-
+#
+#   Copyright (C) 2008 Free Software Foundation, Inc.
+#   This file is part of GNU Libtool.
+#
+# GNU Libtool is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# GNU Libtool is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with GNU Libtool; see the file COPYING.  If not, a copy
+# can be downloaded from  http://www.gnu.org/licenses/gpl.html,
+# or obtained by writing to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+####
+
+AT_SETUP([lt_dlopen error messages])
+AT_KEYWORDS([libltdl])
+
+# The bug is not fixed:
+AT_XFAIL_IF([:])
+
+# This test only works if the system allows undefined symbols.
+eval `$LIBTOOL --config | grep '^allow_undefined_flag='`
+AT_CHECK([test unsupported != "$allow_undefined_flag" || exit 77])
+
+AT_DATA([main.c],
+[[#include <ltdl.h>
+#include <stdio.h>
+
+int
+main (int argc, char* argv[])
+{
+  int err = 0;
+  lt_dlhandle plugin_handle;
+
+  if (argc < 2)
+    {
+      fprintf (stderr, "usage: %s plugin\n", argv[0]);
+      return 1;
+    }
+
+  lt_dlinit ();
+  plugin_handle = lt_dlopenext (argv[1]);
+  if (NULL != plugin_handle)
+    {
+      printf ("plugin opened successfully!\n");
+      lt_dlclose (plugin_handle);
+    }
+  else
+    {
+      printf ("plugin failed to open: %s\n", lt_dlerror());
+      err = 1;
+    }
+  lt_dlexit ();
+  return err;
+}
+]])
+
+AT_DATA([good-plugin.c],
+[[int foo;
+int *i = &foo;
+]])
+
+AT_DATA([missing-symbol-plugin.c],
+[[/* On systems that allow undefined symbols, this will compile,
+     but the symbol "foo" won't be found at runtime */
+extern int foo;
+int *i = &foo;
+]])
+
+: ${LTDLINCL="-I$abs_top_srcdir/libltdl"}
+: ${LIBLTDL="$abs_builddir/../libltdl/libltdlc.la"}
+
+CPPFLAGS="$LTDLINCL $CPPFLAGS"
+inst=`pwd`/inst
+libdir=$inst/lib
+
+AT_CHECK([$CC $CPPFLAGS $CFLAGS -c main.c], [], [ignore], [ignore])
+for file in good-plugin.c missing-symbol-plugin.c; do
+  AT_CHECK([$LIBTOOL --mode=compile $CC $CPPFLAGS $CFLAGS -c $file],
+          [], [ignore], [ignore])
+done
+AT_CHECK([$LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o good-plugin.la -rpath 
$libdir ]dnl
+        [-module -avoid-version good-plugin.lo], [], [ignore], [ignore])
+AT_CHECK([$LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o 
missing-symbol-plugin.la -rpath $libdir]dnl
+        [-module -avoid-version missing-symbol-plugin.lo], [], [ignore], 
[ignore])
+
+AT_CHECK([$LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o main$EXEEXT 
main.$OBJEXT ]dnl
+        [-dlopen good-plugin.la -dlopen missing-symbol-plugin.la $LIBLTDL],
+        [], [ignore], [ignore])
+
+AT_CHECK([./main$EXEEXT ./good-plugin.la], [], [ignore], [ignore])
+AT_CHECK([./main$EXEEXT ./missing-symbol-plugin.la],
+        [1], [ignore], [stderr])
+AT_CHECK([grep 'missing symbol' stderr], [], [ignore])
+
+AT_CLEANUP