Supporting options to assembler and other commands

[Matthijs Kooijman]

Hi,

the current libtool version (2.2.6a) does not support passing options to
commands like the assembler or objdump. This causes libtool in OpenWRT to spit
out errors while running:

  $ ./libtool
  ./libtool: line 46: -c: command not found

This is caused by the following line:

  AS=mips-linux-uclibc-gcc -c -Os -pipe -mips32 -mtune=mips32 -funit-at-a-time 
-fhonour-copts

Putting "" around the value fixes this.

It seems that libtool itself doesn't even use $AS, so it's not critical for
OpenWRT it seems, but this holds for other programs as well (so it might cause
problems for others).

Tracing the cause of this, I find the following lines in configure:

# Assembler program.
AS=$AS

Thise lines are used to generate config.status, which is used to generate
libtool. Adding quotes here (and to a few other variables) would make things
more robust. In fact, the 1.5.26 version seems to have the quotes here.

Some grepping suggests that this line is in turn generated from a similar line
in aclocal.m4, but aclocal.m4 does contain the quotes (and a different
comment, so I'm not sure where that is used:

  # Used on cygwin: assembler.
  AS="$AS"

Some further digging suggests that the line is generated from
libltdl/m4/ltoptions.m4:

  test -z "$AS" && AS=as
  _LT_DECL([], [AS],      [0], [Assembler program])dnl

Not sure how to fix things from here, but I guess you folks know how to do it
from here on. Perhaps fixing the _LT_DECL macro to always generate quotes
might be useful?

I hope you can fix this!

Gr.

Matthijs

signature.asc
Description: Digital signature