Re: Re[2]: libtoolize 2.2.7a is a fork bomb under OpenSolaris

[Ralf Wildenhues]

* Gary V. Vaughan wrote on Sun, Nov 29, 2009 at 07:09:41AM CET:
> On 25 Nov 2009, at 10:49, Vadim Zeitlin wrote:
> > I now see the problem better: the function func_dirname_and_basename()
> > relaunches libtoolize instead of just extracting its dir and base names.
> > And this happens because ECHO variable is empty because as_echo is not
> > defined. So it looks like it _was_ my own fault after all, sorry for the
> > trouble :-( I guess as_echo is only defined by autoconf 2.62, isn't it?
> > 
> > Anyhow, replacing as_echo with just "echo" makes libtoolize work for me.
> 
> Since we have at least two similar reports of this problem (pilot
> error or otherwise), it makes me think that we could make life easier
> for everyone if we either default as_echo to some sensible fallback,
> or at least fail early once libtool detects that as_echo is unset?

Agreed.  OK to commit?
(I'm playing safe in presence of 'info Autoconf Assignments'.)

Thanks,
Ralf

    Sane fallback initialization of $ECHO from $as_echo.
    
    * libltdl/config/general.m4sh: Use 'printf %s\n' if $as_echo is
    unset.
    * tests/testsuite.at: Likewise.
    * THANKS: Update.
    Report by Vadim Zeitlin and Peter Rosin.

diff --git a/libltdl/config/general.m4sh b/libltdl/config/general.m4sh
index fcf75e9..90722bc 100644
--- a/libltdl/config/general.m4sh
+++ b/libltdl/config/general.m4sh
@@ -45,7 +45,7 @@ progpath="$0"
 
 M4SH_VERBATIM([[
 : ${CP="cp -f"}
-: ${ECHO=$as_echo}
+test "${ECHO+set}" = set || ECHO=${as_echo-'printf %s\n'}
 : ${EGREP="@EGREP@"}
 : ${FGREP="@FGREP@"}
 : ${GREP="@GREP@"}
diff --git a/tests/testsuite.at b/tests/testsuite.at
index a4e3458..ea092fc 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -32,6 +32,7 @@ m4_divert_push([PREPARE_TESTS])dnl
 : ${AUTOCONF=autoconf}
 : ${AUTOMAKE=automake}
 : ${AUTORECONF=autoreconf}
+test "${ECHO+set}" = set || ECHO=${as_echo-'printf %s\n'}
 : ${ECHO=$as_echo}
 for tool in ACLOCAL AUTOHEADER AUTOCONF AUTOMAKE AUTORECONF; do
   if eval \$$tool --version >/dev/null 2>&1; then :; else eval $tool=no; fi