Re: [libtool 2.2.8] testsuite: 34 43 67 102 failed (OSF/1 5.1 (old))

[Ralf Wildenhues]

Hello Jay,

* Jay K wrote on Wed, Jun 09, 2010 at 06:17:49PM CEST:
> bash-4.1$ /home/jayk/src/gcc-4.5.0/config.guess 
> alphaev67-dec-osf5.1
> 
> ash-4.1$ uname 
> OSF1 V5.1 732 alpha
> 
> An old odd out of support host, not even 5.1a, but that's your point, eh? :)
> 
> Not sure there's any rpath support here, I think added in 5.1a.
> I gave in and export LD_LIBRARY_PATH=$HOME/lib.

I can't access an OSF1 system for testing right now, but I'm guessing
the patch below should fix this failure for good.  Can you try it, by
running
  make check-local TESTSUITEFLAGS='-v -d -x -k execute'

Can we get a full name for the THANKS and ChangeLog entry?

Test 102 is just a followup failure of the two other ones, which I
haven't analyzed yet.

Thanks,
Ralf

    Fix execute mode test for OSF/1 5.1.
    
    * tests/execute-mode.at (execute mode): Do not use grep -F
    with an empty pattern.
    * THANKS: Update.
    Report by Jay K.

diff --git a/tests/execute-mode.at b/tests/execute-mode.at
index a1a1ee2..55f776c 100644
--- a/tests/execute-mode.at
+++ b/tests/execute-mode.at
@@ -1,6 +1,6 @@
 # execute-mode.at -- libtool --mode=execute             -*- Autotest -*-
 #
-#   Copyright (C) 2008, 2009 Free Software Foundation, Inc.
+#   Copyright (C) 2008, 2009, 2010 Free Software Foundation, Inc.
 #   Written by Ralf Wildenhues, 2008
 #
 #   This file is part of GNU Libtool.
@@ -193,19 +193,19 @@ do
   fi
   AT_CHECK([$LIBTOOL --mode=execute ./foo abc "$arg1" "$arg2" xyz], [], 
[stdout], [ignore])
   AT_CHECK([$FGREP "$arg1" stdout], [], [ignore])
-  AT_CHECK([$FGREP "$arg2" stdout], [], [ignore])
+  AT_CHECK([test -z "$arg2" || $FGREP "$arg2" stdout], [], [ignore])
   AT_CHECK([test `sed -n '/^abc$/,/^xyz$/p' stdout | wc -l` -eq 4])
   AT_CHECK([$LIBTOOL --mode=execute ./lt-wrapper abc "$arg1" "$arg2" xyz 
</dev/null], [], [stdout])
   AT_CHECK([$FGREP "$arg1" stdout], [], [ignore])
-  AT_CHECK([$FGREP "$arg2" stdout], [], [ignore])
+  AT_CHECK([test -z "$arg2" || $FGREP "$arg2" stdout], [], [ignore])
   AT_CHECK([test `sed -n '/^abc$/,/^xyz$/p' stdout | wc -l` -eq 4])
   AT_CHECK([$LIBTOOL --mode=execute ./foo lt-wrapper abc "$arg1" "$arg2" xyz], 
[], [stdout])
   AT_CHECK([$FGREP "$arg1" stdout], [], [ignore])
-  AT_CHECK([$FGREP "$arg2" stdout], [], [ignore])
+  AT_CHECK([test -z "$arg2" || $FGREP "$arg2" stdout], [], [ignore])
   AT_CHECK([test `sed -n '/^abc$/,/^xyz$/p' stdout | wc -l` -eq 4])
   AT_CHECK([$LIBTOOL --mode=execute ./main$EXEEXT abc "$arg1" "$arg2" xyz], 
[], [stdout])
   AT_CHECK([$FGREP "$arg1" stdout], [], [ignore])
-  AT_CHECK([$FGREP "$arg2" stdout], [], [ignore])
+  AT_CHECK([test -z "$arg2" || $FGREP "$arg2" stdout], [], [ignore])
   # Do not match EOL here, cross setups may have an extra \r here.
   AT_CHECK([test `sed -n '/^abc/,/^xyz/p' stdout | wc -l` -eq 4])
   arg1=