bug-libtool
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libtool 2.2.11a] testsuite: 48 69 92 failed [cygwin]


From: Ralf Wildenhues
Subject: Re: [libtool 2.2.11a] testsuite: 48 69 92 failed [cygwin]
Date: Sat, 19 Jun 2010 22:07:12 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

Hi Charles,

* Charles Wilson wrote on Sat, Jun 19, 2010 at 09:07:24PM CEST:
> Well, it turns out there appear to be three separate problems here. Only
> the first of which *really* matters as far as we are concerned.
> 
> See this thread:
> http://cygwin.com/ml/cygwin/2010-06/msg00392.html

Thank you for pursuing this!

> The first patch attached fixes (1), and enables this test to pass on cygwin.

That change is definitely ok!  I think you should commit this first, and
separately from the rest.[1]

> The second one extends/includes the first, but also fixes (2). I moved
> the definition of modexc into libcommon, and linked both module and main
> against it. I left libexc where it was, in liba.

I think this is also ok.  I don't quite understand why the issue (2) is
not exposed for us on Cygwin.  Please leave 48 hours for others to
comment.

> I didn't bother to "fix" (3), since it isn't really exposed here. It
> would be, if we used -regex-symbols or something.

Please add a short comment to this end though.

> As Dave put it, C++ is complicated.  Which solution should I propose on
> libtool-patches? (I'll work up full changelog entries, test on linux &
> mingw, etc, once it's decided which path to pursue).

That would be nice.  My take is that you can commit this, given the
testing, and given that you add a link to this thread or the cygwin
discussion and put a comment in the code why the common lib is needed.

Thanks,
Ralf

[1] If you have a couple of patches A and B, where B includes the
changes from A, you can easily convert that to A and B\A with git
with a sequence like
  ... commit B
  git reset --hard HEAD^
  ... apply and commit A
  git diff address@hidden | git apply

(check with 'git reflog' that address@hidden really is the desired end
state)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]