another func_append inlining regression (was: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit)

[Ralf Wildenhues]

* Rainer Tammer wrote on Thu, Aug 05, 2010 at 09:25:14AM CEST:
> The new test suite still yields many failures in comparison to 2.2.8.

I assume most if not all of the regressions are due to a single issue:

> # grep FAILED check.log
>  38: Link order of deplibs                           FAILED
> (link-order2.at:138)

That fails more or less like this (taken from a test run of mine) in git
master:

../../libtool/tests/link-order2.at:123: $LIBTOOL --mode=link $CC $CFLAGS 
$LDFLAGS $static -o main$EXEEXT main.$OBJEXT libb.la -la0
+ /home/rwild/lt/build-powerpc-ibm-aix5.3.0.0/libtool --mode=link cc 
-qlanglvl=extc89 -g -no-undefined 
-L/home/rwild/lt/build-powerpc-ibm-aix5.3.0.0/tests/t
estsuite.dir/039/lib -o main main.o libb.la -la0
stderr:
stdout:
libtool: link: cc -qlanglvl=extc89 -g -o .libs/main main.o  
-L/home/rwild/lt/build-powerpc-ibm-aix5.3.0.0/tests/testsuite.dir/039/.libs 
-L/home/rwild/lt/bui
ld-powerpc-ibm-aix5.3.0.0/tests/testsuite.dir/039/lib -L./.libs -lb -la1 -la0 
-Wl,-blibpath::/home/rwild/lt/build-powerpc-ibm-aix5.3.0.0/tests/testsuite.dir
/039/lib:/usr/vac/lib:/usr/lib:/lib

Note the double colon after -blibpath, which is due to a regression in
v2.2.10-40-g0da7d80 fixed with the patch below.  I wish I'd never
approved that patch, this one took me so long to find ...

Thanks,
Ralf

    Fix another typo on "Add func_append_quoted and do..."
    
    * libltdl/config/ltmain.m4sh (func_mode_link): Fix regression in
    computation of finalize_rpath introduced in v2.2.10-40-g0da7d80,
    fixing several testsuite failures on AIX.
    Report by Rainer Tammer.

diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index fad2e64..e5065fb 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -7568,7 +7568,7 @@ EOF
              *"$hardcode_libdir_separator$libdir$hardcode_libdir_separator"*)
                ;;
              *)
-               func_append hardcode_libdirs 
"_libdirs$hardcode_libdir_separator$libdir"
+               func_append hardcode_libdirs "$hardcode_libdir_separator$libdir"
                ;;
              esac
            fi