libtool.m4 bug (in sawfish's librep)?

[Daniel Pfeiffer]

 la 12/20/2010 12:42 AM Harald van Dijk skribis:
> On Sun, 2010-12-19 at 21:55 +0100, Daniel Pfeiffer wrote:
> > Your libtool itself has a magic number pointing to bash, necessary
> > because it uses the += operator not understood by other shells.  Yet
> > you contradict that with (only works if your sh is a bash):
> >
> > SHELL=/bin/sh
> > LIBTOOL=$(SHELL) $(top_builddir)/libtool
> > rep_LIBTOOL=$(SHELL) $(top_builddir)/libtool
> This happens if configure is executed by bash, and /bin/sh is not bash.
> If configure is executed by (for example) dash, a dash-compatible
> libtool script will be written.
>
> That said, you're probably right, the $(SHELL) should be removed in
> LIBTOOL and rep_LIBTOOL, but it was added by libtool.m4 (part of libtool
> itself), not anything in librep, so needs to be fixed there.

Having correctly unpacked librep, configure was executable, so I just called 
it as a command.  I know it often says to run "sh configure", but if that is 
required, it should not be executable.  OTOH that would be uncomfortable, 
better to write a makefile that is consistent with the rest.

coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn
Daniel Pfeiffer

--
lerne / learn / apprends / lär dig / ucz się    Esperanto:
                    http://lernu.net  /  http://ikurso.net