Re: libtool 2.4 args parsing incredibly slow

[Ralf Wildenhues]

Hi Peter,

* Peter O'Gorman wrote on Thu, Jan 27, 2011 at 04:19:15AM CET:
> --- a/libltdl/config/ltmain.m4sh
> +++ b/libltdl/config/ltmain.m4sh
> @@ -3195,6 +3195,8 @@ func_exec_program_core ()
>  # launches target application with the remaining arguments.
>  func_exec_program ()
>  {
> +  case \${1+\"address@hidden"} in
> +  *--lt*)

This can be just
  case " $* " in
  *\ --lt*)

>    for lt_wr_arg
>    do
>      case \$lt_wr_arg in
> @@ -3202,7 +3204,8 @@ func_exec_program ()
>      *) set x \"address@hidden" \"\$lt_wr_arg\"; shift;;
>      esac
>      shift
> -  done
> +  done ;;
> +  esac
>    func_exec_program_core \${1+\"address@hidden"}
>  }
> 
> 
> Will avoid the issue if argv doesn't match *--lt-* (surely the most
> common case).

I like this as a first measure.  But can we also reconsider detecting
--lt-* flags only *early* in the command line?  Hmm, since we don't know
which native options accept arguments, that's always painful when
someone wants to be able to do TOOL='./tool --opt1 arg --opt2' and
somebody else appends TOOLFLAGS=--lt-foo, but maybe we can let at least
'--' delimit our search?

Thanks,
Ralf