Re: warnings from openSuSE rpmlint

[Křištof Želechovski]

Dnia piątek, 11 lutego 2011 o 18:02:41 Peter O'Gorman napisał(a):
> On 02/11/2011 10:52 AM, Křištof Želechovski wrote:
> > Dnia piątek, 11 lutego 2011 o 15:25:58 Peter O'Gorman napisał(a):
> >> On 02/11/2011 04:55 AM, Křištof Želechovski wrote:
> >>> libltdl7.x86_64: W: shared-lib-calls-exit /usr/lib64/libltdl.so.7.3.0 
> >>> address@hidden
> >>> This library package calls exit() or _exit(), probably in a non-fork()
> >>> context. Doing so from a library is strongly discouraged - when a library
> >>> function calls exit(), it prevents the calling program from handling the
> >>> error, reporting it to the user, closing files properly, and cleaning up 
> >>> any
> >>> state that the program has. It is preferred for the library to return an
> >>> actual error code and let the calling program decide how to handle the
> >>> situation.
> >>
> >> Although lt__alloc.c contains a definition of lt__alloc_die
> >> (alloc_die_default) which does exit() on memory allocation failures,
> >> this definition is overridden with one that does not in lt_dlinit.
> >
> > Can this definition be removed?
> 
> I don't see why.

If there is a path that leads into the code calling exit, the warning is valid.
If there is no such path, it can be safely removed.
Removing an unneeded and inaccessible function is good: less code, less trouble 
:-)

> 
> >
> > I hope it is a typo for lt_alloc_die?  Double underscores are restricted to 
> > compiler intrinsics and internal symbols of the run-time library, aren’t 
> > they?
> >
> 
> As far as I am aware this restriction is for leading underscores, at 
> least for C.

Indeed, silly me :-)

Thanks,
Chris