bug-libtool
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: warnings from openSuSE rpmlint


From: Ralf Wildenhues
Subject: Re: warnings from openSuSE rpmlint
Date: Sun, 13 Feb 2011 08:25:16 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

Hello,

* Křištof Želechovski wrote on Fri, Feb 11, 2011 at 09:44:28PM CET:
> Dnia piątek, 11 lutego 2011 o 18:02:41 Peter O'Gorman napisał(a):
> > On 02/11/2011 10:52 AM, Křištof Želechovski wrote:
> > > Dnia piątek, 11 lutego 2011 o 15:25:58 Peter O'Gorman napisał(a):
> > >> Although lt__alloc.c contains a definition of lt__alloc_die
> > >> (alloc_die_default) which does exit() on memory allocation failures,
> > >> this definition is overridden with one that does not in lt_dlinit.
> > >
> > > Can this definition be removed?
> > 
> > I don't see why.
> 
> If there is a path that leads into the code calling exit, the warning is 
> valid.
> If there is no such path, it can be safely removed.

Presumably, there is a path that leads into the code calling exit, but
only if ltdl was used outside of its spec (e.g., calling other functions
before lt_dlinit).  So, no, I don't think there are only two
alternatives here.

That said, I'm not sure if there are any users that require the current
construction except when debugging code that uses ltdl.  Anybody else?

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]