Re: Vaticana ligature patch

[Michael Welsh Duggan]

Han-Wen Nienhuys <address@hidden> writes:

> Michael Welsh Duggan wrote:
>
>>>   \remove "Stem_engraver"
>>>   \remove "Ligature_bracket_engraver"
>>>+  \remove "Note_heads_engraver"
>>>+  %% Make sure Vaticana_ligature_engraver comes *before*
>>>+  %% Note_heads_engraver.  This is so it gets the opportunity to
>>> +  %% override the NoteHead stencil 
>
>>> before the NoteHeads take place.
>
> What does this mean? To which code does this refer?

Specifically, it refers to the revert_stencil_callback and
override_stencil_callback functions in Ligature-engraver before
version 1.55 of that file.  Before this change, NoteHead stencils were
modified by a pushpop property into the current context instead of
modifying the grobs' stencil property directly.  As a result, if
NoteHeads were processed before Vaticana_ligature_engraver, the first
NoteHead after the Ligature ended (same time-step) would inherit the
stencil change from the context before Vaticana_ligature_engraver (via
Ligature_engraver) reverted the pushpop_property.

Fortunately, as originally noted, the changes in Ligature_engraver
from v 1.54 to 1.55 obviate the need for the referenced patch.

-- 
Michael Welsh Duggan
(address@hidden)