Re: lilypond-2.17.28 doesn't build with libc++

[David Kastrup]

Joerg Sonnenberger <address@hidden> writes:

> It isn't. It's a bug in Lilypond I had fixed in pkgsrc for the old
> version, but Thomas was missing the various changed for 2.17.28.
> Essentially, lots of files are not including config.h and therefore
> don't have the HAVE_STD_VECTOR_DATA define set.

You mean config.hh and HAVE_STL_DATA_METHOD here.

> Attached is a patchset to fix this.

That seems quite non-sensical.  If std-vector.hh needs to include
config.hh to work, then one should include it in std-vector.hh and not
manually try to include it in every file including std-vector.hh.

> some inconsistencies in the forward type defines

Why would those be problematic?  I find the change ugly.

In my youth, struct and class keywords were exactly equivalent, the sole
difference being the starting accessibility (public for struct, private
for class) in the member declarations.

Has this changed?

-- 
David Kastrup