Re: .../v2.19/Documentation/snippets/tweaks-and-overrides : Drawing boxes around grobs

[David Kastrup]

Pierre Perol-Schneider <address@hidden> writes:

>>I'm not top posting
>
> Hi Squad,
>
> See :
> http://lilypond.org/doc/v2.19/Documentation/snippets/tweaks-and-overrides#tweaks-and-overrides-drawing-boxes-around-grobs
>
> I think this snippet should be re-written since \box function exists plus
> \revert Flag.stencil looks like a typo here (btw, already there in the
> v2.14 litterature).

Not really.  It would seem to have appeared with

commit 72fb864be8e82de810b25a6f39f3f460b7f2b78f
Author: Graham Percival <address@hidden>
Date:   Tue Oct 25 12:01:00 2011 +0100

    Run update-with-convert-ly.sh

And of course the real culprit is

commit 671b7b63408893c33b4c1f196e87db19a7dbcd1e
Author: Mike Solomon <address@hidden>
Date:   Mon Oct 24 08:20:52 2011 +0200

    Creates convert-ly rules to destencil Flags when \override Stem #'stencil = 
##f

Now there is another commit after that:

commit f299c35871038f6d0c959935dcf5f81e29372b86
Author: David Kastrup <address@hidden>
Date:   Mon Oct 24 16:03:00 2011 +0200

    Improve 671b7b6... Creates convert-ly rules to destencil Flags

touching the same rules, but it only polishes the whitespace inserted
for the additional lines.

Basically the rule here is that _any_ revert on the Stem also gets a
revert on the Flag.  Audacious.


It would make sense to review _all_ of

commit 72fb864be8e82de810b25a6f39f3f460b7f2b78f
Author: Graham Percival <address@hidden>
Date:   Tue Oct 25 12:01:00 2011 +0100

    Run update-with-convert-ly.sh

and see whether the application of this somewhat eager convert-ly rule
created other problems.

-- 
David Kastrup