Re: crash during musicxml2ly

[James Lowe]

Hello Frederic,

On Sat, 14 Apr 2018 09:42:20 +0000, Frédéric Gohier <address@hidden> wrote:

> hello,
> 
> I face a crash when run the command line :
> /usr/local/bin/musicxml2ly --nd --nrp --npl --no-beaming -m 
> MusicXMLV2_from_sibelius7.xml
> 
> the traceback is :
> Traceback (most recent call last):
>   File "/usr/local/bin/musicxml2ly", line 3277, in <module>
>     main()
>   File "/usr/local/bin/musicxml2ly", line 3271, in main
>     voices = convert(filename, options)
>   File "/usr/local/bin/musicxml2ly", line 3157, in convert
>     update_score_setup(score, part_list, voices, parts)
>   File "/usr/local/bin/musicxml2ly", line 3027, in update_score_setup
>     score_structure.set_part_information(part_id, staves_info)
>   File "/usr/local/share/lilypond/2.21.0/python/musicexp.py", line 2351, in 
> set_part_information
>     self.contents.set_part_information (part_id, staves_info)
>   File "/usr/local/share/lilypond/2.21.0/python/musicexp.py", line 2135, in 
> set_part_information
>     c.set_part_information (part_name, staves_info)
> AttributeError: PartGroupInfo instance has no attribute 'set_part_information'
> 
> I correct this issue by modifying
> 
>   *   in file git/python/musicexp.py :
>   *   in class StaffGroup :
>   *   in function set_part_information :
> 
>     def set_part_information (self, part_name, staves_info):
>         if part_name == self.id:
>             self.part_information = staves_info
>         else:
>             for c in self.children:
> +                if hasattr(c, 'set_part_information'):
> +                    c.set_part_information (part_name, staves_info)
> -                c.set_part_information (part_name, staves_info)
> 
> 
> I don't know the process to validate and don't remember the process to push a 
> modification on git server.
> please can you help me ?
> 
> 

I can.

You cannot push a modification directly to our git repo until the LilyPond 
developers have reviewed and tested your patch. We use Rietveld for patch 
review and we always need an issue for any patch submitted via Source Forge 
that does not already have an issue against the problem you are trying to fix - 
Allura is our Issue Tracker.

A high level summary is here

http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#summary-for-experienced-developers

If you intend on contributing more I suggest you read the relevant information 
in the Contributor's Guide which tells you how the entire process works.

If you do not want to follow the process, you can at least submit a git 
formatted patch against current master to the bug email list. Current master is 
found here:

https://git.savannah.gnu.org/gitweb/?p=lilypond.git

One of us may be able to start the process of testing and submit the patch for 
review to the rest of the development team.

But we would prefer it if you did try to at least submit your own patch via 
Rietveld if nothing else. 

Thank you.

James