[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: wrong note name conversion in musicxml2ly
From: |
mari+lilypond |
Subject: |
Re: wrong note name conversion in musicxml2ly |
Date: |
Sun, 16 Feb 2020 02:10:36 +0100 |
As far as I understand the closed issue 5746 should fix the problem
musicxml2ly generating the note name "bes" instead of "heses" with
--language=deutsch.
In fact the problem is not fixed in the actual git repository. See my
attached mxl-file and the ly output of
musicxml2ly --language=deutsch --nd --nrp --npl xml_test.mxl
which still contains "bes".
On 2/11/20 5:22 PM, David Kastrup wrote:
> Torsten Hämmerle <address@hidden> writes:
>
>> In any case, the current musicxml2ly problem is about heses. And the heses
>> note name definition in LilyPond (scm/define-note-names.scm) is correct and
>> should not be changed.
>> musicxml2ly must not produce a German "bes", because this clearly should be
>> "heses"
>>
>> Here's the coding for German pitch names:
>>
>>
>> Replacing generic "hes" by "b" is OK, but, that way, generic "heses" will
>> become "bes", wich is clearly wrong and will lead to the error observed.
>>
>> So obviously, it's a problem with *python substring replacement*.
>> I don't know much about python, but replace() doesn't seem to work out here.
>> Probably only a direct string comparison will help here, perhaps someone
>> knowledgeable has a more elegant solution.
>
> Well,
>
> Tracker issue: 5746 (https://sourceforge.net/p/testlilyissues/issues/5746/)
> Rietveld issue: 547610043 (https://codereview.appspot.com/547610043)
> Issue description:
> Fix and align musicxml and input language "deutsch" Has commits:
> In \language "deutsch" use b only to replace hes The quartertone
> names should all be derived from h instead of b since beh was being
> used inconsistently. Fix deutsch language of musicxml2py Use b
> only for hes and nothing else. Also use asas and asah instead of
> ases and aseh.
>
> should fix either. It doesn't use patterns for hes. Somewhat artless.
> So what.
>
xml_test.mxl
Description: application/vnd.recordare.musicxml
xml_test.ly
Description: Text Data