Re: convert-ly rule for tocItem

[Jonas Hahnfeld]

Am Sonntag, den 30.08.2020, 16:48 +0200 schrieb Noeck:
> Am 24.08.20 um 19:54 schrieb Jonas Hahnfeld:
> >  feel free to submit the fix as a merge request 😉
> 
> Hi Jonas,
> 
> I would like to do so and I have the local changes. I am joram-b on gitlab.

Great! :-)

> Could you give me a start?

The CG has some basic information here:
https://lilypond.org/doc/v2.21/Documentation/contributor/uploading-a-patch-for-review

and the underlying process is described here:
https://lilypond.org/doc/v2.21/Documentation/contributor/the-patch-review-cycle
(that's mostly FYI, we'll let you know if we expect you to do something
other than the first link)

> Should I fork lilypond or can I push a branch to lilypond for review?

Yes, a fork would be easiest here. Just open a Merge Request from
there.

> Is there a naming scheme like dev/joram-b/... or should the issue 6024
> be referenced?

The naming scheme only applies to branches in the main repository,
you're free to use whatever you like in your fork (except you shouldn't
just push to master, that results in all kinds of problems). It would
be good to put "Closes #6024" in the last line of the commit message.

> Should I branch from current master?

That would be perfect, but a slightly older version of master as the
base is also fine as long as it doesn't contain other unsubmitted
changes.

Hope this helps, if not please don't hesitate to ask!
Jonas

> Best,
> Joram

signature.asc
Description: This is a digitally signed message part