Re: Internals Reference info-dir-section broken

[John Wheeler]

On 9/1/2021 9:33 AM, Jean Abou Samra wrote:
> Le 31/08/2021 à 23:01, John Wheeler a écrit :
> > The code that creates the file: internals.texi, which is found in 
> > ./scm/documentation-generate.scm and ./scm/documentation-lib.scm, 
> > inserts the following texinfo code near the beginning of the file:
> >
> > INFO-DIR-SECTION LilyPond
> > START-INFO-DIR-ENTRY
> > * GNU LilyPond Internals Reference: (internals). LilyPond Internals 
> > Reference.
> > END-INFO-DIR-ENTRY
> >
> >
> > This texinfo code is incorrect as the reference '(internals)' points 
> > to a non-existent file; it should read '(lilypond-internals)'. It is 
> > also somewhat redundant because the main info dir section for 
> > LilyPond already contains a menu item that points to the correct 
> > file. As far as I can tell, this incorrect code only affects the 
> > internals.info, file so removing it will not impact any other document.
> >
> > I suggest removing this code and have attached a patch to v2.23 that 
> > does that. This patch also removes the function texi-file-head, 
> > because it is only used to create the code above.
> >
> > If you rather I can give a patch that corrects the pointer.
> >
> > Your thoughts?
> >
> > Thank you,
> >
> > John Wheeler
>
>
> Looks good to me. Would you be willing to finish
> the contribution process yourself by putting up a
> merge request? Read the instructions at
>
> http://lilypond.org/doc/v2.23/Documentation/contributor/lifecycle-of-a-merge-request 
>
>
> Someone else can do this for you if you prefer so.
>
> Thanks!
> Jean
I would be happy to.

I hope to make more interesting contributions in the future. This one 
just seemed like a good place to start.

John