Re: v2.23.8: \fine seems to break \midi

[Nikolai Hedler]

I apologize for my curt response in the last email I sent (and forgot to
copy the list); I intended to add more info, but it seems I forgot. The
section I removed during testing starts at line 476 (code beginning at
485), and in my specific use case, simply deleting the entire section (and
the singular reference to it at line 922) and adding \unfoldRepeats in the
MIDI \score resulted in output that seems to be as expected.

- Nikolai


On Fri, Jul 1, 2022 at 4:52 PM Mats Bengtsson <matsboxergrand@gmail.com>
wrote:

> I can't seem to find any implementation of unfoldRepeats in articulate.ly.
> I see that it plays a bit with unfolding, but not by redefining the default
> implementation, as far as I can see. Do you remember what you changed in
> articulate.ly?
>
>    /Mats
> On 2022-07-01 16:42, Nikolai Hedler wrote:
>
> For what it's worth, I deleted the implementation of \unfoldRepeats from
> articulate.ly and found it caused no problems with my scores.
>
> - Nikolai
>
> On Fri, Jul 1, 2022, 10:12 Mats Bengtsson <matsboxergrand@gmail.com>
> wrote:
>
>>    On 2022-06-29 23:28, Dan Eble wrote:
>>
>> On Jun 29, 2022, at 16:14, Jean Abou Samra [1]<jean@abou-samra.fr> wrote:
>>
>> Le 28/06/2022 à 01:33, Nikolai Hedler a écrit :
>>
>>      MIDI ends late if |\fine| followed by a pitch.
>>
>> [2]https://gitlab.com/lilypond/lilypond/-/issues/6368
>>
>>
>>      Beaming and |\fine|
>>
>> [3]https://gitlab.com/lilypond/lilypond/-/issues/6369
>>
>>
>>      Multi-measure rests
>>
>> [4]https://gitlab.com/lilypond/lilypond/-/issues/6370
>> —
>> Dan
>>
>>    Yet another flavor of the problem is that \fine doesn't play well with
>>    \articulate (I know that \articulate only should be used on MIDI
>>    output, but here we can visually see the problems that also are heard
>>    in the MIDI):
>>
>>    \version "2.23.10"
>>    \include "articulate.ly"
>>    \markup "Failing example using \fine"
>>    test_segno = \relative c' {
>>    c1 |
>>    \repeat segno 2 {
>>    e2 c \volta 2 \fine |
>>    g'4 f e d | }
>>    }
>>    \new Staff \test_segno
>>    \new Staff {<>^"\\unfoldRepeats" \unfoldRepeats \test_segno }
>>    \new Staff {<>^"\\articulate \\unfoldRepeats" \articulate
>>    \unfoldRepeats \test_segno }
>>    \new Staff {<>^"\\articulate" \articulate \test_segno }
>>    \markup "Successful example without \fine"
>>    test_volta = \relative c' {
>>    c1 |
>>    \repeat segno 2 {
>>      e2 c |
>>      g'4 f e d |}
>>    c1 |
>>    }
>>    \new Staff \test_volta
>>    \new Staff {<>^"\\unfoldRepeats" \unfoldRepeats \test_volta }
>>    \new Staff {<>^"\\articulate \\unfoldRepeats" \articulate
>>    \unfoldRepeats \test_volta }
>>    \new Staff {<>^"\\articulate" \articulate \test_volta }
>>       /Mats
>>
>> References
>>
>>    1. mailto:jean@abou-samra.fr
>>    2. https://gitlab.com/lilypond/lilypond/-/issues/6368
>>    3. https://gitlab.com/lilypond/lilypond/-/issues/6369
>>    4. https://gitlab.com/lilypond/lilypond/-/issues/6370
>> _______________________________________________
>> bug-lilypond mailing list
>> bug-lilypond@gnu.org
>> https://lists.gnu.org/mailman/listinfo/bug-lilypond
>>
>